[MERGED] ActiveModel.reload has to clear the internal cache [MERGED] #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerc
force-pushed
the
reload-should-clear-the-cache
branch
3 times, most recently
from
c6c2b17
to
375bb11
Compare
Otherwise, one will get stale cache on the freshly reloaded model e.g. `current_state` would return outdated result.
zerc
force-pushed
the
reload-should-clear-the-cache
branch
from
375bb11
to
843cee3
Compare
Unrelated to the changes made.
zerc
commented
Apr 21, 2023
There was a problem hiding this comment.
Not related to this PR it's just rubocop started to complain about this for some reason and I had to make the change.
zerc
commented
Apr 21, 2023
Comment on lines
+52
to
+59
|
|
||
| define_method(:reload) do |*a| | ||
| instance = super(*a) | ||
| if instance.respond_to?(:state_machine, true) | ||
| instance.state_machine.reset | ||
| end | ||
| instance | ||
| end |
There was a problem hiding this comment.
NOTE: this will only work if
include Statesman::Adapters::ActiveRecordQueries
is applied to the target model.
zerc
changed the title
|
PR is merged but for some reason it's not marked as such on Github 😭
|
zerc
changed the title
davegudge
pushed a commit
to skillstream/statesman
that referenced
this pull request
May 26, 2023
…-the-cache ActiveModel.reload has to clear the internal cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #417 the
state.resetmethod was added and suggested to be used together withactive_record.reload.In this PR, I make sure that we apply this logic automatically if
Statesman::Adapters::ActiveRecordQueriesincluded to the model definition so the users don't have to do this themself.