-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 12.0.0. #525
Conversation
benk-gc
commented
Nov 30, 2023
•
edited
edited
- Added multi-database support #522
- This now uses the correct ActiveRecord connection for the model or transition in a multi-database environment
## v12.0.0 30th November 2023 | ||
|
||
### Changed | ||
- Added multi-database support [#522](https://github.com/gocardless/statesman/pull/522) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to include something along the lines of: "use the ActiveRecord connection of the transaction class etc", as that is the actual change. The multi-db support is more of a side effect of using the appropriate connection.
Do we need to update any documentation? Eg. any caveats users need to be aware of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout, updated. The usage and interface of statesman should be exactly the same from a model/transition point of view - the only thing that has changed is the connection used when creating and updating transitions. The major version bump is perhaps an overabundance of caution on my part, but I wanted to make sure this couldn't be silently updated if you're relying on something like dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any database driver specific changes to behaviour that are worth calling out? If not, this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, only internal changes to behaviour detection methods.
49416bc
to
f15f1ba
Compare