Support for event triggered transitions #63
Conversation
|
Nice job. 👍 |
|
This looks great. Are there any issues/limitations with this approach? |
|
This looks incredibly useful. I'm looking at using Statesman on a new project after having using Transitions in the past. Having events makes it easier to wrap transitions in domain language. I may use this fork until it gets pulled in. Thanks @iurimatias! |
|
@mrappleton any thoughts on this? |
|
Whilst I'm not sure I would use a feature like this, there does seem to be a lot of support for it, so I'm happy to go ahead and merge it once a few comments are tidied up. Thanks for the contribution! |
| @@ -189,6 +217,19 @@ def transition_to!(new_state, metadata = nil) | |||
| true | |||
| end | |||
|
|
|||
| def trigger!(event_name, metadata = nil) | |||
| transitions = self.class.events.fetch(event_name) do | |||
| raise Statesman::TransitionFailedError | |||
There was a problem hiding this comment.
It would be good to have a message explaining the error here.
|
Generally looks good! Happy to merge if you could address the comments. |
|
@markquezada Yes, a feature not implemented (yet) is callbacks for the events. |
|
Thanks for the contribution, this will be in v0.8.0 which I'm just about to push to rubygems. |
|
@mrappleton 👍 |
implements #31 and #56 , similar functionality to aasm