bq.py can't handle notFound error

[otofune]

For example, bq --api="http://localhost:9050" --project_id="test" mk --dataset test (with ./bigquery-emulator --project test) failed with following error:

BigQuery error in mk operation: Could not connect with BigQuery server.
Http response status: 404
Http response content:
b'dataset test is not found'

bq checks if dataset/table/etc already exists before creating it. Of course bigquery-emulator already returns 404, but bq can't handle plain text error.

bigquery-emulator/server/middleware.go

Line 182 in d7a7d9a

fmt.Fprintf(w, "job %s is not found", jobID)

I fixed errors by following https://cloud.google.com/bigquery/docs/error-messages with minimal example:

--- a/server/middleware.go
+++ b/server/middleware.go
diff --git a/server/middleware.go b/server/middleware.go
index 7a51ae9..25a8d8a 100644
--- a/server/middleware.go
+++ b/server/middleware.go
@@ -153,8 +153,18 @@ func withDatasetMiddleware() func(http.Handler) http.Handler {
                                dataset := project.Dataset(datasetID)
                                if dataset == nil {
                                        logger.Logger(ctx).Info("dataset is not found", zap.String("datasetID", datasetID))
+                                       w.Header().Add("Content-Type", "application/json")
                                        w.WriteHeader(http.StatusNotFound)
-                                       fmt.Fprintf(w, "dataset %s is not found", datasetID)
+                                       encodeResponse(ctx, w, map[string]interface{}{
+                                               "error": map[string]interface{}{
+                                                       "errors": []interface{}{
+                                                               map[string]interface{}{
+                                                                       "message": fmt.Sprintf("dataset %s is not found", datasetID),
+                                                                       "reason":  "notFound",
+                                                               },
+                                                       },
+                                               },
+                                       })
                                        return
                                }
                                ctx = withDataset(ctx, dataset)

[goccy]

I read the error dofcumentation ( https://cloud.google.com/bigquery/docs/reference/rest/v2/ErrorProto ).
Also, when I read the source code of bq.py, it seems that notFound must be returned as the reason. I'll fix it !

[goccy]

I fixed this problem with v0.1.15 . Thank you !