Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascade dataset deletes to tables #164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cascade dataset deletes to tables #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9665b91
Cascade dataset deletes to tables
sbv-csis Mar 7, 2023
35b9b1a
Merge branch 'goccy:main' into fix-dataset-casacde
sbv-csis Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/metadata/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,14 @@ func (r *Repository) DeleteDataset(ctx context.Context, tx *sql.Tx, dataset *Dat
); err != nil {
return err
}
if _, err := tx.Exec(
"DELETE FROM tables WHERE projectID = @projectID AND datasetId = @id",
dataset.ProjectID,
dataset.ID,
); err != nil {
return err
}

return nil
}

Expand Down