fix: add a fallback uint8 sliceDecoder to bytesDecoder

fix #360
goccy · Apr 7, 2022 · d9df77a · d9df77a
1 parent 3a4ad31
commit d9df77a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/decode_test.go b/decode_test.go
@@ -3907,3 +3907,14 @@ func TestIssue342(t *testing.T) {
 		t.Errorf("unexpected result: got(%v) != expected(%v)", got, expected)
 	}
 }
+
+func TestIssue360(t *testing.T) {
+	var uints []uint8
+	err := json.Unmarshal([]byte(`[0, 1, 2]`), &uints)
+	if err != nil {
+		t.Errorf("unexpected error: %v", err)
+	}
+	if len(uints) != 3 || !(uints[0] == 0 && uints[1] == 1 && uints[2] == 2) {
+		t.Errorf("unexpected result: %v", uints)
+	}
+}
diff --git a/internal/decoder/bytes.go b/internal/decoder/bytes.go
@@ -23,9 +23,8 @@ func byteUnmarshalerSliceDecoder(typ *runtime.Type, structName string, fieldName
 		unmarshalDecoder = newUnmarshalJSONDecoder(runtime.PtrTo(typ), structName, fieldName)
 	case runtime.PtrTo(typ).Implements(unmarshalTextType):
 		unmarshalDecoder = newUnmarshalTextDecoder(runtime.PtrTo(typ), structName, fieldName)
-	}
-	if unmarshalDecoder == nil {
-		return nil
+	default:
+		unmarshalDecoder, _ = compileUint8(typ, structName, fieldName)
 	}
 	return newSliceDecoder(unmarshalDecoder, typ, 1, structName, fieldName)
 }