Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime validation #4

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Add runtime validation #4

merged 1 commit into from
Jul 24, 2020

Conversation

goccy
Copy link
Owner

@goccy goccy commented Jul 24, 2020

If the internal structure of reflect package changes in the future, it will panic when executing init .

@codecov-commenter
Copy link

Codecov Report

Merging #4 into master will decrease coverage by 20.95%.
The diff coverage is 4.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
- Coverage   97.41%   76.46%   -20.96%     
===========================================
  Files           5        6        +1     
  Lines         503      650      +147     
===========================================
+ Hits          490      497        +7     
- Misses         12      105       +93     
- Partials        1       48       +47     
Impacted Files Coverage Δ
init.go 4.76% <4.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f031ee7...feb6392. Read the comment docs.

@goccy goccy merged commit 5a14ec6 into master Jul 24, 2020
@goccy goccy deleted the feature/add-runtime-validator branch July 24, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants