Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-yaml should support encoding.TextMarshaler / encoding.TextUnmarshaler, shouldn't it? #73

Closed
kyoh86 opened this issue Jan 11, 2020 · 1 comment · Fixed by #74
Closed

go-yaml should support encoding.TextMarshaler / encoding.TextUnmarshaler, shouldn't it? #73

kyoh86 opened this issue Jan 11, 2020 · 1 comment · Fixed by #74

Comments

@kyoh86
Copy link
Contributor

kyoh86 commented Jan 11, 2020 •
edited

json.Marshal / json.Unmarshal calls MarshalText / UnmarshalText to marshal / unmarshal object which implements encoding.TextMarshaler / encoding.TextUnmarshaler.
Primitive objects often implement them.
@kyoh86 kyoh86 changed the title go-yaml should support encode.TextMarshaler / encode.TextUnmarshaler, shouldn't it? go-yaml should support encoding.TextMarshaler / encodeing.TextUnmarshaler, shouldn't it? Jan 11, 2020
@kyoh86 kyoh86 changed the title go-yaml should support encoding.TextMarshaler / encodeing.TextUnmarshaler, shouldn't it? go-yaml should support encoding.TextMarshaler / encoding.TextUnmarshaler, shouldn't it? Jan 11, 2020
@kyoh86 kyoh86 mentioned this issue Jan 11, 2020
Merged
@kyoh86
Copy link
Contributor Author

kyoh86 commented Feb 11, 2020

ref: go-yaml/yaml#38

@goccy goccy closed this as completed in #74 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support encoding.TextMarshaler/TextUnmarshaler
1 participant
@kyoh86