Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Date] Base date used when parsing is start of unix time, not 0001-01-01 #143

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Jan 29, 2024

Closes #136

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Merging #143 (4964ad6) into main (7d3a82f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   45.82%   45.78%   -0.04%     
==========================================
  Files          47       47              
  Lines       17800    17802       +2     
==========================================
- Hits         8156     8150       -6     
- Misses       8182     8193      +11     
+ Partials     1462     1459       -3     

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@goccy goccy merged commit 7b48c5e into goccy:main Jan 30, 2024
6 checks passed
@ohaibbq ohaibbq deleted the dan/base-date branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Date] Incorrect initial date used for parsing dates
3 participants