Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Array] Fix ordinal boundary indexing #155

Merged
merged 1 commit into from
Mar 9, 2024
Merged

[Array] Fix ordinal boundary indexing #155

merged 1 commit into from
Mar 9, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 1, 2024

Closes #148

goccy
goccy approved these changes Mar 9, 2024
View reviewed changes
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !!! LGTM 👍

@goccy goccy merged commit 4505d46 into goccy:main Mar 9, 2024
6 checks passed
@ohaibbq ohaibbq deleted the dan/ordinal-boundary branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goccy goccy goccy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Arrays] Ordinal indexing does not properly handle last-element ordinal
2 participants
@ohaibbq @goccy