Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter] Fix syntax error that occurred for some queries using subselects or QUALIFY #157

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 1, 2024

This also reduces the number of sub-selects that are necessary to aid cases which result in #153

Closes #147
Closes #150

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Merging #157 (5fddf4a) into main (961ce06) will increase coverage by 0.68%.
Report is 12 commits behind head on main.
The diff coverage is 44.44%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   46.39%   47.07%   +0.68%     
==========================================
  Files          47       47              
  Lines       17828    17886      +58     
==========================================
+ Hits         8271     8420     +149     
+ Misses       8111     8002     -109     
- Partials     1446     1464      +18     

internal/formatter.go Outdated Show resolved Hide resolved
@goccy goccy added the reviewed label Mar 9, 2024
@goccy goccy merged commit d5aff7d into goccy:main Mar 10, 2024
6 checks passed
@goccy
Copy link
Owner

goccy commented Mar 10, 2024

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants