Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Do not cast integer/float-like strings to datetime #184

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 27, 2024

Closes #175

@codecov-commenter
Copy link

Codecov Report

Merging #184 (635786c) into main (961ce06) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   46.39%   46.48%   +0.09%     
==========================================
  Files          47       47              
  Lines       17828    17820       -8     
==========================================
+ Hits         8271     8284      +13     
+ Misses       8111     8092      -19     
+ Partials     1446     1444       -2     

@ohaibbq
Copy link
Contributor Author

ohaibbq commented Feb 27, 2024

This will also require a change in bigquery-emulator repository.go to handle parsing of timestamps when adding table data

@ohaibbq
Copy link
Contributor Author

ohaibbq commented Mar 9, 2024

The bigquery-emulator change has been merged to our fork here- https://github.com/Recidiviz/bigquery-emulator/pull/7/files

There's conflicts with the upstream repo until goccy/bigquery-emulator#271 is merged.

@goccy
Copy link
Owner

goccy commented Mar 10, 2024

Thank you for your contribution ! LGTM 👍

@goccy goccy merged commit 745096f into goccy:main Mar 10, 2024
6 checks passed
@ohaibbq ohaibbq deleted the dan/string-to-time branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAST(string AS DATETIME) incorrectly parses integer strings as date
3 participants