Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QUALIFY without GROUP BY / WHERE / HAVING #201

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Mar 28, 2024

Closes #123

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Merging #201 (0557eea) into main (745096f) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 55.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   47.82%   47.87%   +0.05%     
==========================================
  Files          47       47              
  Lines       17923    17930       +7     
==========================================
+ Hits         8571     8584      +13     
+ Misses       7910     7907       -3     
+ Partials     1442     1439       -3     

internal/analyzer.go Outdated Show resolved Hide resolved
@ohaibbq
Copy link
Contributor Author

ohaibbq commented Apr 8, 2024

@goccy I've updated the variable scope

@goccy
Copy link
Owner

goccy commented Apr 8, 2024

Thank you !!! LGTM 👍

@goccy goccy merged commit 93d2c40 into goccy:main Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUALIFY clause without WHERE or GROUP_BY or HAVING
3 participants