Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability for plugin to store global configuration #1121

Closed
4 tasks done
srinivasupadhya opened this issue May 11, 2015 · 1 comment
Closed
4 tasks done

Provide ability for plugin to store global configuration #1121

srinivasupadhya opened this issue May 11, 2015 · 1 comment

Comments

@srinivasupadhya
Copy link
Contributor

some plugins might need ability to store configuration. eg: github plugin might need username & password for updating PR status, artifact cleanup plugin might want to take configuration of "how many instances to keep" etc.

Currently this is being done through system property, configuration file (in location specified by plugin) etc. If Go server provides standardized approach to store configuration all plugins could take advantage of this.


Implementation:

  • Plugin provides "configuration" keys & settings template
  • Go Server on the plugins listing page provides a "configure" icon (super admins only), on click of which it renders pop-up with template & data (if its already stored)
  • On save the data (key-value pairs) is passed to plugin for validation. On success they are stored as JSON to database
  • Plugin will be able to access the configuration through GoApplicationAccessor message "get-configuration"

The data will be stored in a seperate table plugin which has id as plugin-id & column data which is JSON representation of key-value pairs

@srinivasupadhya srinivasupadhya added this to the Release 15.2 milestone May 11, 2015
@srinivasupadhya srinivasupadhya self-assigned this May 11, 2015
srinivasupadhya added a commit to srinivasupadhya/gocd that referenced this issue May 14, 2015
srinivasupadhya added a commit to srinivasupadhya/gocd that referenced this issue May 14, 2015
srinivasupadhya pushed a commit to srinivasupadhya/gocd that referenced this issue May 18, 2015
srinivasupadhya pushed a commit to srinivasupadhya/gocd that referenced this issue May 18, 2015
…-> JSONResultMessageHandler + namespace plugin-settings request names
@mdaliejaz mdaliejaz self-assigned this Jun 15, 2015
@mdaliejaz
Copy link
Contributor

Verified. Works fine on 15.2.0(2093-c20772b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants