Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user needs a spinner while searching for user #1279

Closed
zabil opened this issue Jun 29, 2015 · 2 comments
Closed

Add user needs a spinner while searching for user #1279

zabil opened this issue Jun 29, 2015 · 2 comments
Assignees
@juhijariwala
Labels
enhancement ui / ux
Milestone
Release 15.3

Comments

@zabil
Copy link
Contributor

zabil commented Jun 29, 2015

Authentication plugin extension allows a plugin to query external sources for user search.
The current modal does not display a loading status when search takes time to return result. (For e.g while accessing the Github user API)

Expected.
Display a spinner
@zabil zabil mentioned this issue Jul 28, 2015
Closed
37 tasks
@jyotisingh jyotisingh added this to the Release 15.3 milestone Jul 28, 2015
juhijariwala added a commit to juhijariwala/gocd that referenced this issue Sep 8, 2015
@juhijariwala
gocd#1279 Moved spinner css class on search-box to
c259740 
right place to display spinner on user search.
srinivasupadhya added a commit that referenced this issue Sep 10, 2015
@srinivasupadhya
Merge pull request #1482 from juhijariwala/user_search_spinner
5ca3b98 
Moved css class to show spinner while searching for user in add user window #1279.
@rajiesh
Copy link
Contributor

rajiesh commented Sep 21, 2015

preliminary test of this story on trunk 4da012b

Using chrome v 43.0
Note: this behavior not observed on firefox

The spinner is not shown during the first search,

  • Setup Go Server to use LDAP or use GitHub login plugin
  • Login as Admin - navigate to user summary - click add user
  • Search for any user(ldap/git)
  • The first search will not have the spinner, the subsequent searches shows the spinner
  • Navigate to any other tabs/page(eg., pipeline) and visit User summary page and try add user - The first search will not have spinner, subsequent searches will show spinner

Below screen shot was taken after hitting the search button, search icon disappears but spinner does not appear

image

juhijariwala added a commit to juhijariwala/gocd that referenced this issue Oct 27, 2015
@juhijariwala
Fix for spinner is not shown on the first search issue(gocd#1279).
8eaaa38
jyotisingh added a commit that referenced this issue Oct 29, 2015
@jyotisingh
Merge pull request #1581 from juhijariwala/fix_spinner
928d426 
Fix for spinner is not shown on the first search issue(#1279).
@rajiesh
Copy link
Contributor

rajiesh commented Nov 9, 2015

this issue verified on 15.3.0-2597 build and confirmed to be working fine without the issue of first time search not sowing up the spinner

@zabil zabil closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juhijariwala juhijariwala

Labels
enhancement ui / ux
Projects
None yet
Milestone
Release 15.3
Development

No branches or pull requests
5 participants
@zabil @jyotisingh @srinivasupadhya @juhijariwala @rajiesh