Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper error message on UI and in logs when re-run of an older version of a pipeline fails due to change in configuration #27

Closed
pravds opened this issue Mar 26, 2014 · 1 comment

Comments

@pravds
Copy link
Contributor

pravds commented Mar 26, 2014

Steps to Reproduce

  1. Create a pipeline which fetches artifact from ancestor pipeline and run it once (Run 1).
  2. Now change pipeline configuration such that artifact is now fetched from different ancestor pipeline and run again (Run 2).
  3. Go to Run 1 of pipeline and re-run stage.
Stack trace:

ERROR [92@MessageListener for WorkFinder] JMSMessageListenerAdapter:54 - Exception thrown in message handling by listener com.thoughtworks.cruise.server.messaging.scheduling.WorkFinder@17924f73
java.lang.NullPointerException
    at com.thoughtworks.cruise.server.service.builders.FetchTaskBuilder.resolveTargetJob(FetchTaskBuilder.java:76)
    at com.thoughtworks.cruise.server.service.builders.FetchTaskBuilder.createBuilder(FetchTaskBuilder.java:29)
    at com.thoughtworks.cruise.server.service.builders.FetchTaskBuilder.createBuilder(FetchTaskBuilder.java:25)
    at com.thoughtworks.cruise.server.service.builders.BuilderFactory.builderFor(BuilderFactory.java:47)
    at com.thoughtworks.cruise.server.service.builders.BuilderFactory.buildersForTasks(BuilderFactory.java:41)
    at com.thoughtworks.cruise.server.service.BuildAssignmentService$2.surrounding(BuildAssignmentService.java:188)
    at com.thoughtworks.cruise.server.transaction.TransactionTemplate.transactionSurrounding(TransactionTemplate.java:55)
    at com.thoughtworks.cruise.server.service.BuildAssignmentService.createWork(BuildAssignmentService.java:175)
    at com.thoughtworks.cruise.server.service.BuildAssignmentService.assignWorkToAgent(BuildAssignmentService.java:99)
    at com.thoughtworks.cruise.server.messaging.scheduling.BuildAssignmentServiceAssigner.assignWorkToAgent(BuildAssignmentServiceAssigner.java:28)
    at com.thoughtworks.cruise.server.messaging.scheduling.WorkFinder.onMessage(WorkFinder.java:34)
    at com.thoughtworks.cruise.server.messaging.scheduling.WorkFinder.onMessage(WorkFinder.java:13)
    at com.thoughtworks.cruise.server.messaging.activemq.JMSMessageListenerAdapter.runImpl(JMSMessageListenerAdapter.java:49)
    at com.thoughtworks.cruise.server.messaging.activemq.JMSMessageListenerAdapter.run(JMSMessageListenerAdapter.java:34)
    at java.lang.Thread.run(Thread.java:662)

Actual Result

No message displayed on UI to indicate why pipeline did not trigger.

Expected Result

Proper error message should be displayed on UI and logs to indicate why pipeline did not trigger.

@pravds pravds added the bug label Mar 26, 2014
pravds pushed a commit that referenced this issue Apr 24, 2014
…n fetch artifact task builder fails due to config change
@arvindsv arvindsv modified the milestone: Unknown - Needs interest from someone Jan 4, 2016
@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days.
If you can still reproduce this error on the master branch using local development environment or on the latest GoCD Release, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

@stale stale bot added the stale label Apr 2, 2020
@stale stale bot closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants