Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment API should support patch for environment variables #3080

Closed
mortenherman opened this issue Jan 6, 2017 · 2 comments
Closed

Environment API should support patch for environment variables #3080

mortenherman opened this issue Jan 6, 2017 · 2 comments
Assignees
@GaneshSPatil
Labels
apis bug
Milestone
Release 17.3

Comments

@mortenherman
Copy link

Issue Type

Feature enhancement

Summary

When using the environment API of the go server, I noticed that if I want to create or change environment variables in an environment I can only use the put method on environments API.
However this comes with the side effect, that to add environment variables I would also have to extract agents, pipelines and existing environment variables to patch the variables, and then "PUT" the entire environment specification to the GO server again.

the current PATCH /go/api/admin/environments/:environment_name does only support patching of pipelines and agents, and it would of great benefit to have support for patching environment variables as well.

Environment

GO Server 16.11

information on API can be found here:
https://api.gocd.io/current/#patch-an-environment

  • Go Version: 16.11
  • JAVA Version: 1.8.0_101
  • OS:Windows Server 2012 R2 6.3
@ketan
Copy link
Member

ketan commented Jan 6, 2017

Hi — thank you for reporting this issue. This looks like a good candidate for outside contribution. The code change is fairly small and localized —

Would you be willing to submit a PR, the team is around to help you out with any questions that you might have.

@arvindsv arvindsv added this to the Release 17.2 milestone Jan 19, 2017
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jan 20, 2017
@GaneshSPatil
Add PATCH support for environment-variables in Environments API (gocd…
2e3a24f 
…#3080)
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jan 22, 2017
@GaneshSPatil
Add PATCH support for environment-variables in Environments API (gocd…
dbae71e 
…#3080)
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jan 23, 2017
@GaneshSPatil
API V2 of Environments to support PATCH environment variables operati…
204a144 
…ons (gocd#3080).
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jan 25, 2017
@GaneshSPatil
API V2 of Environments to support PATCH environment variables operati…
9adef51 
…ons (gocd#3080).
@rajiesh rajiesh modified the milestones: Release 17.3, Release 17.2 Feb 21, 2017
varshavaradarajan pushed a commit that referenced this issue Feb 28, 2017
@GaneshSPatil @varshavaradarajan
Add PATCH support for environment-variables in Environments API (#3080)…
6986dcc 
… (#3109)

* ApiV2 of environments config
* Allow updating environment variables using PATCH api of environments.
* Remove environments with remote from api_v1
@rajiesh
Copy link
Contributor

rajiesh commented Mar 22, 2017

Verified on GoCD version 17.3.0 (4701-42a55e643a6e6a39ca07ce6bc00df7b4be2a28df)

@rajiesh rajiesh closed this as completed Mar 22, 2017
@GaneshSPatil GaneshSPatil added this to the Release 17.3 milestone Mar 24, 2017
@ankitsri11 ankitsri11 mentioned this issue Apr 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GaneshSPatil GaneshSPatil

Labels
apis bug
Projects
None yet
Milestone
Release 17.3
Development

No branches or pull requests
5 participants
@ketan @arvindsv @rajiesh @mortenherman @GaneshSPatil