Agents Page Memory Leak Fix #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not passing key to the memoize method will take object reference as key by default. Whereas on each poll we create a new agent object, and the memoize treats the newly created agent object as a new agent and will cache it seperately. This was causing memoize to cache all the objects leading to memory overflow.
GaneshSPatil
changed the title
|
fixes #3187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass resolver which specifies the key to be cached for the given agent
Not passing key to the memoize method will take object reference as key by default.
Whereas on each poll we create a new agent object, and the memoize treats the newly created agent object as a new agent and will cache it separately.
This was causing memoize to cache all the objects leading to memory overflow.