Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an identifier on config repo tag #3648

Closed
GaneshSPatil opened this issue Jul 12, 2017 · 0 comments
Closed

Add an identifier on config repo tag #3648

GaneshSPatil opened this issue Jul 12, 2017 · 0 comments
Milestone
Release 17.8

Comments

@GaneshSPatil
Copy link
Contributor

Issue Type
  • Feature enhancement
Summary

To uniquely identify a config repository, add an id field on <configrepo> tag

current configrepo tag
<config-repo plugin="json.config.plugin">
     <git url="https://github.com/tomzo/gocd-json-config-example.git" />
</config-repo>
expected configrepo tag
<config-repo id="9cad79b0-4d9e-4a62-829c-eb4d9488062f" plugin="json.config.plugin">
     <git url="https://github.com/tomzo/gocd-json-config-example.git" />
</config-repo>
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jul 13, 2017
@GaneshSPatil
Add 'id' as a unique identifier on config-repo tag (gocd#3648)
0d26142 
* New config-repo tag example:

<config-repo plugin="json.config.plugin" id="9271a1c8-b1ee-4a76-868a-36ffaa349ecc">
	<git url="https://github.com/bob/gocd-json-config-example.git" />
</config-repo>
varshavaradarajan pushed a commit that referenced this issue Jul 13, 2017
@GaneshSPatil @varshavaradarajan
Add 'id' as a unique identifier on config-repo tag (#3651)
76de32c 
* Add 'id' as a unique identifier on config-repo tag (#3648)
* New config-repo tag example:

<config-repo plugin="json.config.plugin" id="9271a1c8-b1ee-4a76-868a-36ffaa349ecc">
	<git url="https://github.com/bob/gocd-json-config-example.git" />
</config-repo>

* Add duplicate and empty config-repo id validation
@varshavaradarajan varshavaradarajan added this to the Release 17.8 milestone Jul 15, 2017
@rajiesh rajiesh modified the milestones: Release 17.8, Release 17.9 Aug 2, 2017
This was referenced Aug 22, 2017
Closed
Closed
@arvindsv arvindsv mentioned this issue Aug 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 17.8
Development

No branches or pull requests
3 participants
@varshavaradarajan @rajiesh @GaneshSPatil