Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass along JobIdentifier for Elastic Agent Plugins #4091

Closed
GaneshSPatil opened this issue Dec 13, 2017 · 2 comments
Closed

Pass along JobIdentifier for Elastic Agent Plugins #4091

GaneshSPatil opened this issue Dec 13, 2017 · 2 comments
Labels
plugins
Milestone
Release 18.4

Comments

@GaneshSPatil
Copy link
Contributor

Issue Type
  • Feature enhancement
Summary

Pass along JobIdentifier to the elastic agent plugins for making better decisions while:

  • create-agent request

    • JobIdentifier information will be used by the plugins for making better decisions about creating a new container for the current create-agent request.
      If the plugin has already scheduled a request for creating an agent for the given jobIdentifier, on the next create-agent call, the plugin can skip the agent creation.

  • should-assign-work request

    • JobIdentifier information will be used by the plugins for making better decisions about assigning a job to a particular agent.
      The plugin can make a decision based on whether the current agent was brought up for the given jobIdentifier or not.
@GaneshSPatil GaneshSPatil added this to the Release 18.1 milestone Dec 13, 2017
@GaneshSPatil
Copy link
Contributor Author

Related: gocd/kubernetes-elastic-agents#3

@GaneshSPatil GaneshSPatil mentioned this issue Dec 13, 2017
Closed
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Dec 13, 2017
@GaneshSPatil
Pass along JobIdentifier to createAgent request for elasticAgent plug…
7f192e8 
…ins gocd#4091
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Dec 14, 2017
@GaneshSPatil
Pass along JobIdentifier to createAgent request for elasticAgent plug…
d477d19 
…ins gocd#4091
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Dec 14, 2017
@GaneshSPatil
Pass along JobIdentifier to should-assign-work request for elasticAge…
c76ae2c 
…nt plugins gocd#4091
GaneshSPatil added a commit that referenced this issue Dec 19, 2017
@GaneshSPatil
Merge pull request #4094 from GaneshSPatil/pass-job-identifier-to-ela…
a3ba5b0 
…stic-agent-plugin-extension

Pass along JobIdentifier to createAgent request for elasticAgent plugins #4091
@GaneshSPatil
Copy link
Contributor Author

Pass along JobIdentifier to the elastic agent plugins for making better decisions while:

  • status-report request

    • JobIdentifier information will be used by the plugins for highlighting the container which is running the current job on the status report page.

    • Currently, navigating from build_details_page to status_report_page doesn't show the relation between which container is running the current job.

    • JobIdentifier is optional for status-report page. It is only provided while navigating from build_details_page. JobIdentifier won't be provided while navigating from elastic_profile_page and plugins_page.

@GaneshSPatil GaneshSPatil mentioned this issue Dec 20, 2017
Closed
3 tasks
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Dec 20, 2017
@GaneshSPatil
Pass along jobIdentifier as part of get-status-report request to the …
c3a3f46 
…elastic agent plugins

* JobIdentifier is only passed when the request for  'status report page' made from 'build details page'.
* JobIdentifier wont be passed to the plugin when the request for 'status report page' is made from 'plugin settings page' or 'elastic profile page'.

More information: gocd#4091 (comment)
@GaneshSPatil GaneshSPatil mentioned this issue Dec 20, 2017
Closed
GaneshSPatil added a commit to GaneshSPatil/kubernetes-elastic-agents that referenced this issue Dec 20, 2017
@GaneshSPatil
Use JobIdentifier information provided as part of get-status-report r…
5c229d4 
…equest to show the relation between job and pod

* Highlight the pod running the job when jobIdentifier is provided as part of the get-status-report page
* Show normal status report page when no job-identifier is passed as part of the get-status-report request

More information: gocd/gocd#4091
@GaneshSPatil GaneshSPatil mentioned this issue Dec 20, 2017
Closed
GaneshSPatil added a commit to GaneshSPatil/gocd that referenced this issue Jan 16, 2018
@GaneshSPatil
Pass along jobIdentifier as part of get-status-report request to the …
3ee15e2 
…elastic agent plugins

* JobIdentifier is only passed when the request for  'status report page' made from 'build details page'.
* JobIdentifier wont be passed to the plugin when the request for 'status report page' is made from 'plugin settings page' or 'elastic profile page'.

More information: gocd#4091 (comment)
@rajiesh rajiesh modified the milestones: Release 18.1, Release 18.2 Jan 24, 2018
@rajiesh rajiesh modified the milestones: Release 18.2, Release 18.3 Mar 8, 2018
@rajiesh rajiesh modified the milestones: Release 18.3, Release 18.4 Apr 19, 2018
@varshavaradarajan varshavaradarajan mentioned this issue May 8, 2018
Open
@rajiesh rajiesh closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
Release 18.4
Development

No branches or pull requests
2 participants
@rajiesh @GaneshSPatil