Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard UI rendering duplicate pipeline information #4775

Closed
Diogomrol opened this issue May 23, 2018 · 5 comments
Closed

Dashboard UI rendering duplicate pipeline information #4775

Diogomrol opened this issue May 23, 2018 · 5 comments
Labels
Dashboard
Milestone
Release 18.6

Comments

@Diogomrol
Copy link

Hello there,

After upgrading to GoCD 18.5.0 I noticed that there is a bug in the new Dashboard that is duplicating/triplicating the pipeline info.

I can't really understand the root cause, but this started to happen after I unpaused a pipeline.

Screenshot:

imagem

Cheers,
Diogo Oliveira
@arvindsv
Copy link
Member

A few questions I should have asked earlier:

  1. Does it go away (fix itself) if you refresh?

  2. Does it go away (fix itself) if you restart?

  3. Did you just unpause and this happened? Any other steps you can think of? Was this pipeline created recently?

Thank you!

@Diogomrol
Copy link
Author

@arvindsv, so answering your questions:

  1. It does go away if I refresh the page
  2. I didn't need to restart, because 1) fixed the problem
  3. I was able to notice this behavior twice: on the first time I only unpaused the pipeline. On the second time, I unpaused the pipeline and then clicked on "Play".

Something that might be relevant: the pipeline is not new. However, it was the first time I ran it after upgrading from GoCD 17.10.0 to 18.5.0.

Thank you :)

@ketan
Copy link
Member

ketan commented May 24, 2018

@Diogomrol — if this happens again, would you mind opening chrome dev tools and capturing a screenshot of any errors that show up?

@Diogomrol
Copy link
Author

It just happened. Here it is:

gobug

@jyotisingh
Copy link
Contributor

Thanks @Diogomrol, we were able to replicate this at our end too and are working on a fix for the same.

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 1, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
d2587a6 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 5, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
c10fc76 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 5, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
d89cfeb 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 5, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
cc2fed1 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 5, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
594227b 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 6, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
95f399f 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 6, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
bb3ed94 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
@jyotisingh jyotisingh added this to the Release 18.6 milestone Jun 6, 2018
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 6, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
e141c91 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit to jyotisingh/gocd that referenced this issue Jun 6, 2018
@jyotisingh
Fixed issue of duplicate html elements showing up on new dashboard - g…
89b7991 
…ocd#4775

Foundation components were being used for buttonWithTooltip and linkWithTooltip. While these worked in most cases, when such elements are present of pages which get refreshed by some ajax call (as was the case on dashboard), the destruction of these foundation elements (if the element was to be removed from the UI) wasn't clean and lead to issues. The first call to component.onremove would succeed but mithil kept a reference of the old/deleted element and called onremove on it all over again leading to onremove call failing. Since oncreate was being called before onremove, the element wasn't really deleted from the UI. Using a custom html component instead to solve this.
jyotisingh added a commit that referenced this issue Jun 6, 2018
@jyotisingh
Merge pull request #4802 from jyotisingh/issue_4775
58e85fc 
Fixed issue of duplicate html elements showing up on new dashboard -#4775
@rajiesh rajiesh closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dashboard
Projects
None yet
Milestone
Release 18.6
Development

No branches or pull requests
6 participants
@ketan @arvindsv @jyotisingh @rajiesh @Diogomrol @GaneshSPatil