Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation modal on server config SPA and improvements #7372

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Confirmation modal on server config SPA and improvements #7372

merged 2 commits into from
Dec 10, 2019

Conversation

vrushaliwaykole
Copy link
Contributor

@vrushaliwaykole vrushaliwaykole commented Dec 4, 2019 •
edited
Loading

Issue:
#7383

Description:

  • Added confirmation for discarding unsaved changes when user navigates through left navigation on server config SPA.
  • Add spinner on page load.

@vrushaliwaykole vrushaliwaykole added this to the Release 19.12.0 milestone Dec 4, 2019
@vrushaliwaykole
Copy link
Contributor Author

vrushaliwaykole commented Dec 4, 2019 •
edited
Loading

Confirmation modal on SeverConfig SPA for left navigation -

confirmmodal

cc:/ @adityasood Does the question There are unsaved changes. Do you want to discard the changes? on the modal sounds good?

@vrushaliwaykole vrushaliwaykole changed the title Added confirmation modal on server config SPA. Confirmation modal on server config SPA and imrpovements Dec 6, 2019
@vrushaliwaykole vrushaliwaykole changed the title Confirmation modal on server config SPA and imrpovements Confirmation modal on server config SPA and improvements Dec 6, 2019
@vrushaliwaykole
Copy link
Contributor Author

vrushaliwaykole commented Dec 6, 2019 •
edited
Loading

Updated message and button styles for modal -

Screenshot 2019-12-06 at 2 30 48 PM

@vrushaliwaykole vrushaliwaykole merged commit f91099a into gocd:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrushaliwaykole vrushaliwaykole

@dhanasp dhanasp

Labels
server-configuration-rewrite ui / ux
Projects
None yet
Milestone
Release 19.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vrushaliwaykole @dhanasp