Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelled icon is not rendered of cancelled jobs on stage details page #7472

Closed
GaneshSPatil opened this issue Dec 19, 2019 · 4 comments
Closed

Cancelled icon is not rendered of cancelled jobs on stage details page #7472

GaneshSPatil opened this issue Dec 19, 2019 · 4 comments
Labels
bug good-first-issue hacktoberfest Issues for first-time contributors pipeline runs
Projects
20.1.0
Milestone
Release 20.1.0

Comments

@GaneshSPatil
Copy link
Contributor

GaneshSPatil commented Dec 19, 2019 •
edited

Issue Type
  • Bug Report
Summary

The canceled icon is not rendered for the canceled jobs on the stage details page.

Link: https://build.gocd.org/go/pipelines/build-linux-PR/5862/build-server/2/overview

Screen Shot 2019-12-19 at 11 23 06 AM

Basic environment details
  • Go Version: 19.12.0
Steps to Reproduce
  1. Create a pipeline with job(s).
  2. Trigger pipeline and cancel the stage.
  3. Visit the stage details page of the pipeline instance.
  4. Refer failed jobs section on the left
@GaneshSPatil GaneshSPatil added this to the NextUp milestone Dec 19, 2019
@kritika-singh3
Copy link
Contributor

@GaneshSPatil I'm unable to reproduce the error.
Steps I followed:

  1. Create a pipeline with 3 jobs with all of them failing
  2. Triggered the job.
  3. Visited the stage details page.

Screen Shot 2020-01-02 at 2 19 04 PM

Can you verify it on your end.

@GaneshSPatil
Copy link
Contributor Author

@kritika-singh3 -- The issue is with the canceled stage jobs (not failed).
I've updated the steps to reproduce this issue.

@kritika-singh3
Copy link
Contributor

Able to reproduce the issue. Confirmed that the issue is present from GoCD version 19.8.0 post the changes made in #6707.

@kritika-singh3 kritika-singh3 mentioned this issue Jan 2, 2020
Merged
@kritika-singh3 kritika-singh3 modified the milestones: NextUp, Release 20.1.0 Jan 13, 2020
@kritika-singh3 kritika-singh3 added this to In progress in 20.1.0 Jan 13, 2020
@GaneshSPatil
Copy link
Contributor Author

Verified on GoCD Version: 20.1.0 (11114-f2c1771e333ea92dae82cd78d2efa1310c1086f0).

Example: https://build.gocd.org/go/pipelines/smoke/3325/Smoke/1

@GaneshSPatil GaneshSPatil moved this from In progress to Done in 20.1.0 Jan 30, 2020
@GaneshSPatil GaneshSPatil moved this from Done to QA Done in 20.1.0 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue hacktoberfest Issues for first-time contributors pipeline runs
Projects
No open projects
20.1.0
  
QA Done
Milestone
Release 20.1.0
Development

No branches or pull requests
2 participants
@GaneshSPatil @kritika-singh3