Change GoCD to no longer force links to open in new windows/tabs #10520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
remove_window_opens
branch
from
d8f8a2d
to
e4bc97d
Compare
|
Hey @chadlwilson - the changes LGTM. Lets wait to get an agreement if we want to make this change based on this comment Also, |
chadlwilson
force-pushed
the
remove_window_opens
branch
from
e4bc97d
to
26baa0f
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
26baa0f
to
4d3db4b
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
4d3db4b
to
bcaef92
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs. |
chadlwilson
force-pushed
the
remove_window_opens
branch
from
bcaef92
to
22ffcf8
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
22ffcf8
to
6ccf724
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
6ccf724
to
1ae8581
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
2 times, most recently
from
d4179da
to
565a7e9
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
565a7e9
to
9567a8c
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
9567a8c
to
040fe7f
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
040fe7f
to
62f6fad
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
3 times, most recently
from
42bd9f7
to
9adc03f
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
9adc03f
to
49abac3
Compare
chadlwilson
force-pushed
the
remove_window_opens
branch
from
49abac3
to
6601429
Compare
Internal links will open by default in the same window/tab, returning control to the user to be able to middle-click for new tab/window, and shift/middle-click for new background tabs, reducing a relatively age-old user complaint about excessive tabs being opened, and getting lost in tabs. External and docs links continue to generally open in new tabs for now; with this change to make the "external link icons" consistent across places, so you have a good idea if something is going to open in a new tab from the visual description of the link. There are some old non-Typescript pages which don't do this still unfortunately.
chadlwilson
force-pushed
the
remove_window_opens
branch
from
6601429
to
80cde32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9526, related to #9613
Internal links will open by default in the same window/tab, returning control to the user to be able to middle-click (CMD + click) for new tab/window, and shift/middle-click for new background tabs, reducing a relatively age-old user complaint about excessive tabs being opened, and getting lost in tabs.
External and docs links continue to generally open in new tabs for now, but link display has been made more consistent to generally give a good indicaation with the icon if something is about to force-open in a new tab, e.g
