Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#000 Removed/Upgraded libs that's pulling older versions of xerces #1171

Merged
merged 1 commit into from
Jun 10, 2015
Merged

#000 Removed/Upgraded libs that's pulling older versions of xerces #1171

merged 1 commit into from
Jun 10, 2015

Conversation

zabil
Copy link
Contributor

@zabil zabil commented Jun 2, 2015

This to fix the problem of

WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.

These warnings are printed when you have xerces on the classpath. A newer version of the JDK(8) does not fix this. The only solution is to get rid of xerces (which now comes bundled with the idk) as a transitive dependency.

This pull request fix it only on some modules.

Apache shindig (used on our app) hard wires the xerces dependency and modules referring shindig will still print this error. For a long term solution we should upgrade the version of Apache shindig.

@jyotisingh
Copy link
Contributor

This changes make sense, but would not fix the warnings when Go server runs. Probably affects test runs only. Anyway, could you sync your changes with upstream so I could proceed with the merge.

@ketan
Copy link
Member

ketan commented Jun 10, 2015

This changes make sense, but would not fix the warnings when Go server runs. Probably affects test runs only. Anyway, could you sync your changes with upstream so I could proceed with the merge.

@jyotisingh I've seen these warnings in production code as well.

@zabil
Copy link
Contributor Author

zabil commented Jun 10, 2015

Will be solved in production code once we finish this #1169

@jyotisingh
Copy link
Contributor

@ketan - Yes the warnings show up in production as well, thats exactly what I meant when I said when Go server runs. I am okay to merge these changes as the dependencies which were removed in the pr did not make sense in the first place.

jyotisingh added a commit that referenced this pull request Jun 10, 2015
#000 Removed/Upgraded libs that's pulling older versions of xerces
@jyotisingh jyotisingh merged commit 3e05075 into gocd:master Jun 10, 2015
@ketan ketan added this to the Release 15.2 milestone Jun 23, 2015
@zabil zabil deleted the xercesDependencyCleanup branch May 31, 2016 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants