Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: bumps lru-cache from 7.18.3 to latest #11722

Closed
wants to merge 1 commit into from

Conversation

chadlwilson
Copy link
Member

@chadlwilson chadlwilson commented Jun 29, 2023

Bumps lru-cache to latest.

Still has some kind of issue:

ERROR in ./node_modules/lru-cache/dist/mjs/index.js 24:15
Module parse failed: Unexpected token (24:15)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     //@ts-ignore
|     AS = class AbortSignal {
>         onabort;
|         _onabort = [];
|         reason;
 @ ./webpack/helpers/time_formatter.ts 60:18-38
 @ ./webpack/single_page_apps/show_stage_duration_graph_shim.tsx

Seems to use https://babeljs.io/docs/babel-plugin-proposal-class-properties in dist output so probably points to some kind of webpack or babel misconfiguration. Maybe re-assess after we can move to webpack 5 in #10852 ?

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 14 days. It will be closed in 7 days if no further activity occurs.
Thank you for your contributions!

@stale stale bot added the stale label Sep 17, 2023
@chadlwilson chadlwilson added no stalebot Don't mark this stale. and removed stale labels Sep 17, 2023
@chadlwilson
Copy link
Member Author

Blocked on WebPack 5 ( #10852 )

@chadlwilson chadlwilson deleted the bump-lru-cache branch October 14, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stalebot Don't mark this stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant