Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build, test and package GoCD with Java 21 LTS by default #12762

Merged
merged 2 commits into from
May 14, 2024

Conversation

chadlwilson
Copy link
Member

@chadlwilson chadlwilson commented May 13, 2024

There seem to be no issues with using Java 21 by default at runtime, so let's get this going for build.gocd.org so we can smoke test things.

@chadlwilson chadlwilson added this to the Release 24.2.0 milestone May 13, 2024
@chadlwilson chadlwilson changed the title Package GoCD with Java 21 LTS Build, test and package GoCD with Java 21 LTS by default May 14, 2024
@chadlwilson chadlwilson marked this pull request as ready for review May 14, 2024 03:05
@chadlwilson
Copy link
Member Author

chadlwilson commented May 14, 2024

Core Java/gradle unit tests and ruby functional/regression tests are all fine when running under Java 21, however running sprockets asset precompile via sass-embedded and dart-sass is currently broken on Java 21 (which prevents running the rails/ruby unit tests under Java 21).

Not sure of root cause, but trying at sass-contrib/sass-embedded-host-ruby#208 for now.

@chadlwilson chadlwilson merged commit 79b945a into gocd:master May 14, 2024
1 check passed
@chadlwilson chadlwilson deleted the java21 branch May 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant