upgrade rails 2.3.14 to 4.0.4 #130

bsharanya · 2014-04-25T08:59:08Z

Go uses a 2.3.x release of Rails, which recently got deprecated. It causes Go to not be able to take advantage of new improvements in Rails. Causes people to have to use antiquated Rails contsructs rather than the new ones. We haven't been able to upgrade till now since rails 3 is not backward compatible & it's a daunting task to migrate all views at once - because of API changes in Rails, dependency on JRuby, RSpec and other gems. It feels like one upgrade was missed a few years ago and then it was too late.

Tasks:
Will need to first upgrade JRuby and Jetty to the newer revisions, since newer Rails releases do not support the old JRuby revision that is used (corresponds to Ruby 1.8.6). Then, need to do a pretty big upgrade to all Rails code in the codebase. Need to bring in Bundler into the codebase for gem management.
Biggest hurdles will be:

Default ERB syntax has changed, so most ERB files will not work out of the box, but will silently fail when viewed (will show ERB code on the rendered page).
RSpec needs to be upgraded, since the old gem will not work with the new JRuby/Rails combination. Most tests will fail.

sachinsudheendra · 2014-04-26T15:01:11Z

Assigning it to @bsharanya as this task has started

xiaods · 2014-04-28T15:50:04Z

@bsharanya we can create a rails4 branch to do patch by patch. sharing the branch, let us going on it. I am very interesting the migration process. please let us can involved.

srinivasupadhya · 2014-04-29T12:41:00Z

TODO: #149

srinivasupadhya · 2014-04-30T04:30:11Z

@xiaods we are going to try trunk based development with feature toogle for this, so you should be able to see the changes on the main repo.

Currently we are doing some ground work for this like library updates (jruby-complete, jruby-rack) & gem updates (rails, rspec etc.). Trying to get the spec server running the specs. Once this much is done you can start contributing by fixing the specs/controllers/views etc.

Does that make sense? Looking forward to your contribution.

#130 - Remove RubyRuntimeFinder. Not used.

xiaods · 2014-04-30T13:30:01Z

@srinivasupadhya yes, I will follow your suggestion to do some research on this codebase. let me have a try.

juniorz · 2014-04-30T15:29:24Z

Considering the current Rails version (2.3.4) I assume the project uses vendorized gems without Bundler.

Migrating to a bundler-based setup is a requirement to this update, what about creating a different issue for that (which could be made without changing the Rails version)?

juniorz · 2014-04-30T16:06:47Z

However, JRuby at tools/jruby is at version 1.8.6 and is incompatible with latest bundler

$ gocd/tools/jruby/bin/jruby -S gem install bundler
ERROR:  Error installing bundler:
    bundler requires Ruby version >= 1.8.7

$ gocd/tools/jruby/bin/jruby -S gem install bundler -v=1.0
ERROR:  Error installing bundler:
    bundler requires RubyGems version >= 1.3.6

$ gocd/tools/jruby/bin/jruby -S gem --version
1.3.5

Unfortunately, according to Bundler compatibility list the minimum version for rubygems is 1.3.6.

I was trying to find a way to decouple the introduction of Bundle, this upgrade, the "ground work" @srinivasupadhya is currently doing and #149 but I don't think it's possible.

@srinivasupadhya , is there any issue created for this "ground work"?

created new rake file for this. RAILS_WORKING_DIR is 'rails.new' moved command to run tests from script/spec to rspec fixed format of rspec-extra-formatters create spec_helper: rails new myapp --skip-active-record --skip-javascript --skip-test-unit; cd myapp; add rspec & rspec-rails in Gemfile; bundle install; rails generate rspec:install; copy spec_helper.rb into rails.new/spec added dummy model & spec command to run spec: ./tools/bin/go.jruby -S rake --rakefile server/run_rspec_tests_use_new_rails.rake spec

./tools/bin/go.jruby -S gem install rspec --no-ri --no-rdoc ./tools/bin/go.jruby -S gem install rspec-rails --no-ri --no-rdoc ./tools/bin/go.jruby -S gem install rspec-extra-formatters --no-ri --no-rdoc install gems required to run rspec tests

For the tests, we load the Spring application context, which starts activemq, ehcache, h2, etc. which start daemon threads, which do not allow rspec to finish (and exit) once the tests are done (when run using autorun). Explicitly exit with the status code.

#130 - Make rspec exit after successful run.

./tools/bin/go.jruby -S gem install spork -v=1.0.0rc4 --no-rdoc --no-ri

#130 Add support to spork to rails.new tests

#130 - move backup_controller to rails.new

Had to move feeds_helpers & the spec for it as part of this. Commented out pipeline_details_url from feeds_helper as it needs a bunch of other things.

#130 - Fixed bug. rails.new/spec was getting packaged in installers

#130 - UI fixes

Because of the script tag not being closed, the next script, which was the one which set contextPath (var contextPath = ...) was not getting executed. Was causing many pages to fail rendering.

#130 - Fix script tag. Fixes many issues.

#130 - Fix broken Velocity pages for old rails after assets changes

* The class_eval action_view_extension.rb was being used to omit id generation for fields. Since ':id => nil' does the same task, replacing omit_id_generation with that. * Have added tests in few places. Didn't add tests for partials where new spec files were required to be added as it's a very small change.

* The action_view_extension.rb was used to provide omit_id_generation tag to omit the generation of id for the specified field. The usage of omit_id_generation has been replaced with ':id => nil' which does the same job of omitting the id from the specified fields. * This class also provided the to_check_box_tag with the ability to remove the hidden field tag from the field if required. This tag is no longer valid in Rails 4 and is not being used in the migrated classes.

* Using Ruby 1.9 hash syntax and added missing spaces around the braces.

…tinue working on those.

* The class_eval action_view_extension.rb was being used to omit id generation for fields. Since ':id => nil' does the same task, replacing omit_id_generation with that. * Have added tests in few places. Didn't add tests for partials where new spec files were required to be added as it's a very small change.

* The action_view_extension.rb was used to provide omit_id_generation tag to omit the generation of id for the specified field. The usage of omit_id_generation has been replaced with ':id => nil' which does the same job of omitting the id from the specified fields. * This class also provided the to_check_box_tag with the ability to remove the hidden field tag from the field if required. This tag is no longer valid in Rails 4 and is not being used in the migrated classes.

* Using Ruby 1.9 hash syntax and added missing spaces around the braces.

* Reverting the commit as inlining of partials wouldn't happen if Hound's feedbacks are incorporated.

…n production mode. Rails will continue to serve it in development mode. This is done to help with performance.

…xt is started

#130 - Implemented code-walkthrough feedback

#130 - Moved the usage of 'omit_id_generation=>true' to ':id=>nil'

arikagoyal · 2014-11-04T06:16:51Z

All rails 4 issues seem to be fixed

sachinsudheendra assigned bsharanya Apr 26, 2014

srinivasupadhya mentioned this issue Apr 29, 2014

upgrade jruby used for packaging #147

Closed

arikagoyal added enhancement and removed technical labels Apr 29, 2014

srinivasupadhya changed the title ~~upgrade rails 2.3.14 to 4.x~~ upgrade rails 2.3.14 to 4.0.4 Apr 30, 2014

mdaliejaz added a commit that referenced this issue Apr 30, 2014

Merge pull request #153 from srinivasupadhya/master

2259930

#130 - Remove RubyRuntimeFinder. Not used.

juniorz mentioned this issue Apr 30, 2014

remove jruby (1.3.1) after rspec upgrade #149

Closed

juniorz mentioned this issue May 5, 2014

Upgrades Rails from 2.3.4 to 2.3.18 #167

Closed

srinivasupadhya added a commit that referenced this issue May 8, 2014

#130 - fixing build. bouncycastle needs to be packaged in agent.

8c26d4b

srinivasupadhya added a commit that referenced this issue May 8, 2014

Merge pull request #176 from arvindsv/master

b4b01a4

#130 - Make rspec exit after successful run.

juniorz added a commit to juniorz/gocd that referenced this issue May 8, 2014

gocd#130 Add support to spork to rails.new tests

1cabad9

./tools/bin/go.jruby -S gem install spork -v=1.0.0rc4 --no-rdoc --no-ri

srinivasupadhya mentioned this issue May 10, 2014

refactor code after rails upgrade #181

Closed

srinivasupadhya added a commit that referenced this issue May 12, 2014

Merge pull request #178 from juniorz/spork

ac66e0a

#130 Add support to spork to rails.new tests

juniorz mentioned this issue May 12, 2014

Add pipelines_controller to new Rails app #182

Merged

bsharanya added a commit that referenced this issue May 19, 2014

Merge pull request #180 from srinivasupadhya/master

f51bcf3

#130 - move backup_controller to rails.new

bsharanya added a commit to bsharanya/gocd that referenced this issue May 20, 2014

gocd#130 - Moved api/users_controller to rails 4.

83684b2

Had to move feeds_helpers & the spec for it as part of this. Commented out pipeline_details_url from feeds_helper as it needs a bunch of other things.

bsharanya added a commit to bsharanya/gocd that referenced this issue May 20, 2014

gocd#130 - Moving api/server_controller to new rails format.

50137b2

bsharanya added a commit to bsharanya/gocd that referenced this issue May 21, 2014

gocd#130 - Merged main gocd repo commits

3e7c9f0

sachinsudheendra added a commit that referenced this issue Sep 16, 2014

Merge pull request #512 from jyotisingh/Bugfix

7fa9fe2

#130 - Fixed bug. rails.new/spec was getting packaged in installers

sachinsudheendra added a commit that referenced this issue Sep 16, 2014

Merge pull request #514 from ermauliks/master

3e3c499

#130 - UI fixes

arvindsv added a commit that referenced this issue Sep 16, 2014

Merge pull request #521 from arvindsv/fix_script_tag_assets_issue

a22bceb

#130 - Fix script tag. Fixes many issues.

ermauliks added a commit to ermauliks/gocd that referenced this issue Sep 17, 2014

gocd#130 - Fix broken Velocity pages for old rails after assets changes

783fb43

jyotisingh added a commit that referenced this issue Sep 17, 2014

Merge pull request #524 from ermauliks/master

df07e58

#130 - Fix broken Velocity pages for old rails after assets changes

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Sep 22, 2014

gocd#130 - Incorporating the Hound's feedback.

1507bbd

* Using Ruby 1.9 hash syntax and added missing spaces around the braces.

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Sep 22, 2014

gocd#130 - Incorporating the Hound's feedback.

0a5f5d4

* Using Ruby 1.9 hash syntax and added missing spaces around the braces.

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Sep 23, 2014

gocd#130 - Added dependency on jasmine-jquery-rails

599937f

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Sep 23, 2014

gocd#130 - ported jsunit tests in jasmine for rails-new

50ef1b2

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Sep 23, 2014

gocd#130 - Fixed jasmine tests. Ignoring few others for now, will con…

f37bbc1

…tinue working on those.

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Sep 23, 2014

gocd#130 - deleting unnecessary html fixture

d66c56e

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Oct 1, 2014

gocd#130 - Incorporating the Hound's feedback.

6effff6

* Using Ruby 1.9 hash syntax and added missing spaces around the braces.

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Oct 1, 2014

Revert "gocd#130 - Incorporating the Hound's feedback."

ca99748

* Reverting the commit as inlining of partials wouldn't happen if Hound's feedbacks are incorporated.

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Oct 3, 2014

gocd#130 - Removing the puts which was pushed upstream by mistake.

53b46cd

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Oct 7, 2014

gocd#130 - Assets (css, images, and js) will now be served by jetty i…

36ec052

…n production mode. Rails will continue to serve it in development mode. This is done to help with performance.

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Oct 7, 2014

gocd#130 - AssetsContextHandler will be initialized after WebAppConte…

a66ccfc

…xt is started

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Oct 7, 2014

gocd#130 - Implemented code-walkthrough feedback

fdcfc98

jyotisingh added a commit to jyotisingh/gocd that referenced this issue Oct 8, 2014

gocd#130 - Implemented code-walkthrough feedback

a1f7217

pravds added a commit that referenced this issue Oct 8, 2014

Merge pull request #627 from jyotisingh/rails4_assets

c08ce3b

#130 - Implemented code-walkthrough feedback

mdaliejaz added a commit to mdaliejaz/gocd that referenced this issue Oct 9, 2014

gocd#130 - Changing to new Ruby 1.9 hash syntax in the specs.

fa28e02

arvindsv added a commit that referenced this issue Oct 13, 2014

Merge pull request #557 from mdaliejaz/omit_id_generation

3737deb

#130 - Moved the usage of 'omit_id_generation=>true' to ':id=>nil'

arikagoyal closed this as completed Nov 4, 2014

mdaliejaz unassigned bsharanya Nov 5, 2014

arvindsv mentioned this issue Aug 16, 2022

Upgrade from Rails 5.2 to Rails 6.1 #10699

Merged

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade rails 2.3.14 to 4.0.4 #130

upgrade rails 2.3.14 to 4.0.4 #130

bsharanya commented Apr 25, 2014

sachinsudheendra commented Apr 26, 2014

xiaods commented Apr 28, 2014

srinivasupadhya commented Apr 29, 2014

srinivasupadhya commented Apr 30, 2014

xiaods commented Apr 30, 2014

juniorz commented Apr 30, 2014

juniorz commented Apr 30, 2014

arikagoyal commented Nov 4, 2014

upgrade rails 2.3.14 to 4.0.4 #130

upgrade rails 2.3.14 to 4.0.4 #130

Comments

bsharanya commented Apr 25, 2014

sachinsudheendra commented Apr 26, 2014

xiaods commented Apr 28, 2014

srinivasupadhya commented Apr 29, 2014

srinivasupadhya commented Apr 30, 2014

xiaods commented Apr 30, 2014

juniorz commented Apr 30, 2014

juniorz commented Apr 30, 2014

arikagoyal commented Nov 4, 2014