Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move elastic profiles /usages api to internal path #5583

Merged

Conversation

vishaldevgire
Copy link
Contributor

@vishaldevgire vishaldevgire commented Dec 17, 2018

Changes:

  • Created a new controller for api/internal/elastic/profiles/profile_id/usages API (this is required since the base path has changed)
  • Moved ElasticProfileUsageRepresenter class to new package
  • Changed ElasticProfileSPA to use internal path for /usages API

@GaneshSPatil
Copy link
Contributor

This is not necessary for the current release. Marking it for 19.1.0

@GaneshSPatil GaneshSPatil added this to the Release 19.1.0 milestone Dec 17, 2018
@bdpiprava bdpiprava merged commit 439e3a5 into gocd:master Dec 19, 2018
@bdpiprava bdpiprava deleted the move_elastic_profile_usage_api_to_intenal branch December 19, 2018 14:12
@maheshp maheshp added this to In progress in 19.1.0 via automation Jan 10, 2019
@maheshp maheshp moved this from In progress to Done in 19.1.0 Jan 10, 2019
@rajiesh rajiesh moved this from Done to QA Done in 19.1.0 Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
19.1.0
  
QA Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants