Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go's version to 1.13.x and use Go modules #131

Merged
merged 1 commit into from Dec 23, 2019

Conversation

martincapello
Copy link
Contributor

This PR upgrades Go to use the 1.13.x version and leverages the use of Go modules instead of the dep tool.

Signed-off-by: martincapello <m.a.capello@gmail.com>
@yashbhutwala
Copy link

yashbhutwala commented Dec 18, 2019

+1 to this initiative 😃

Copy link
Member

@yoonsio yoonsio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! as long as you have tested this.

@martincapello
Copy link
Contributor Author

martincapello commented Dec 23, 2019

Oh yeah, I have just tested it using travis and coveralls on my fork and all went good!
Question, who should merge this? Am asking because I don't have write access to the repository, so I cannot do it by myself 😟

@yoonsio yoonsio merged commit b83d9b8 into gocelery:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants