Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support set custom redis queue name #140

Closed
wants to merge 2 commits into from

Conversation

leason00
Copy link

support set custom redis queue name

Copy link
Member

@yoonsio yoonsio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I think it might be better to expose this by using public variable instead.

@@ -52,6 +52,11 @@ func (cb *RedisCeleryBroker) SendCeleryMessage(message *CeleryMessage) error {
return nil
}

//Set custom queue name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break lint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.
Do you mean like this?
`// RedisCeleryBroker is celery broker for redis
type RedisCeleryBroker struct {
*redis.Pool
QueueName string
}

// NewRedisBroker creates new RedisCeleryBroker with given redis connection pool
func NewRedisBroker(conn *redis.Pool, queueName string) *RedisCeleryBroker {
return &RedisCeleryBroker{
Pool: conn,
QueueName: queueName,
}
}`

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break lint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@yoonsio
Copy link
Member

yoonsio commented Jul 14, 2020

Sorry but I have to close this PR request. I think this should be applied to all brokers/backends.
I already merged the changes into the master: #144
This should solve your problem.

@yoonsio yoonsio closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants