Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Empty Tx Contract Address Field #283

Closed
jmank88 opened this issue Apr 30, 2019 · 2 comments · Fixed by #288
Closed

Hide Empty Tx Contract Address Field #283

jmank88 opened this issue Apr 30, 2019 · 2 comments · Fixed by #288

Comments

@jmank88
Copy link
Contributor

jmank88 commented Apr 30, 2019

The Contract Address field should only appear if the tx created a contract.
Screenshot from 2019-04-30 09-52-51
https://testnet-explorer.gochain.io/tx/0x9b7a0581897443a0194795651f3f7e1fe6eea893d86b62d3104eb4c53c0ef1b2
bergauz added a commit that referenced this issue May 1, 2019
@bergauz
show contract addr only for successful tx in tx page, resolves #283
99ccf3e
@bergauz bergauz mentioned this issue May 2, 2019
Merged
r-gochain pushed a commit that referenced this issue May 9, 2019
@bergauz @r-gochain
Nonce & tx page fixes (#288)
ba46827 
* show contract addr only for successful tx in tx page, resolves #283

* margin style fix

* empty nonce fix, resolves #113

* fixed: dark theme contract function groups unreadable, resolves #284
@jmank88 jmank88 reopened this May 9, 2019
@jmank88
Copy link
Contributor Author

jmank88 commented May 9, 2019 •
edited
Loading

This still needs work. The status of a tx is not relevant. The problem is an empty address being sent instead of null.

@jmank88
Copy link
Contributor Author

jmank88 commented May 9, 2019

Screenshot_20190509-054703
#288 (comment)

bergauz added a commit that referenced this issue May 11, 2019
@bergauz
hide empty tx contract address field, related to #283
0021cf8
r-gochain pushed a commit that referenced this issue May 11, 2019
@bergauz @r-gochain
Improvements & fixes (#302)
50cd34b 
* improved contract verification, related #211

* hide empty tx contract address field, related to #283

* removed default gas limit from contract form, related to #255

* renamed button on transaction success page, related to #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nonce & tx page fixes gochain/explorer
1 participant
@jmank88