Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Tx table 'GO' column #46

Closed
jmank88 opened this issue Jun 1, 2018 · 7 comments
Closed

Format Tx table 'GO' column #46

jmank88 opened this issue Jun 1, 2018 · 7 comments

Comments

@jmank88
Copy link
Contributor

jmank88 commented Jun 1, 2018

Should we format this tx column like in #28 ?
screenshot from 2018-06-01 12-39-37
Perhaps it should be right-aligned as well.

@bergauz
Copy link
Contributor

bergauz commented Sep 29, 2018

screen shot 2018-09-29 at 11 13 21

so it's formatted. about right alignment: i think if we are going to do this we need to unify digits qty after comma so it'll be obvious to user, either there's no sense to do it

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 29, 2018

Is it easy to align on the decimal?

 123.456
  12.2345
1234.5

Maybe also drop the per-line GO and just have it up top like VALUE (GO) or something?

@bergauz
Copy link
Contributor

bergauz commented Oct 8, 2018

screenshot 2018-10-08 at 13 46 24

@jmank88 Droped per line GO, but it's difficult to aligning on decimal since it's dynamic list, put fixed fraction

bergauz added a commit to bergauz/explorer that referenced this issue Oct 8, 2018
@bergauz bergauz mentioned this issue Oct 8, 2018
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 8, 2018

I'm worried a fixed fraction is going to be a problem. Can we do the max 18 decimals, but replace trailing zeros with spaces?

Whatever we do, the rich list should be the same:

screenshot from 2018-10-08 09-08-03

r-gochain added a commit that referenced this issue Oct 9, 2018
@bergauz
Copy link
Contributor

bergauz commented Oct 9, 2018

screenshot 2018-10-10 at 02 47 04

@jmank88
Copy link
Contributor Author

jmank88 commented Oct 9, 2018

Looking good! Is that font not fixed-width? That should help the alignment - in fact, the whole table could probably use a fixed-width font.

bergauz added a commit to bergauz/explorer that referenced this issue Oct 15, 2018
@bergauz
Copy link
Contributor

bergauz commented Oct 15, 2018

screenshot 2018-10-15 at 18 50 53

screenshot 2018-10-15 at 18 51 09

@jmank88 jmank88 closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants