Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a failed webhook delivery prevents it from being delivered again (with different args). #210

Closed
eri-trabiccolo opened this issue Nov 19, 2020 · 1 comment · Fixed by #205
Assignees
Labels
Severity: Normal Status: Has PR This issue has an open pull request Type: Bug Bugs and errors

Comments

@eri-trabiccolo
Copy link
Contributor

eri-trabiccolo commented Nov 19, 2020

Reproduction Steps

Expected Behavior

  • I would expect the second webhook to be delivered

Actual Behavior

Error Messages / Logs

n/a

System Information

System Report
LifterLMS Rest 1.0.0-beta.16

Browser, Device, and Operating System Information

n/a

Related User Information

HS-140845

Solution here would be to not store the pending_delivery and, of course, not relying on this.
I've investigated a little bit into this and IF (as it seems) the reason why we use it is to avoid delivery duplicate within the same request, then we should use a different approach, e.g. looking at our inspiration:
woocommerce/woocommerce@b262ac8#diff-8971231b02d400aadd63a60794ca17128d5dd8e9ed670745f6785ec8d9425128

Additionally, the same inspiring software, uses the pending_delivery only for deciding whether or not a delivery ping should be performed: sends the delivery ping only if pending_delivery is set to 1 (and this value is set on the webhook creation).

We use a different approach to determine it, and already don't rely on the pending_delivery property.
(I think we could even get rid of it...)

@thomasplevy
Copy link
Contributor

Thumbs up <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Normal Status: Has PR This issue has an open pull request Type: Bug Bugs and errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants