PHP Warning on courses (membership) archive when no course (membership) catalog set

[eri-trabiccolo]

Reproduction Steps

• Unset, if ever set, the course catalog page under LifterLMS -> Settings -> Courses -> Course Catalog
• Visit your example.com/courses/ page
• (make sure you either display warnings or log them)

Expected Behavior

• I'd expect to see the catalog with no warnings

Actual Behavior

• PHP warnings logged

Solution suggested by @kimcoleman

this is the line: https://github.com/gocodebox/lifterlms/blob/trunk/includes/functions/llms.functions.templates.loop.php#L62
Should we consider check if $page_id is > 0 OR $page isn’t empty before we set $content = $page->post_content;?

Error Messages / Logs

• Include any relevant error messages or log files

[31-Jul-2023 07:11:46 UTC] PHP Warning:  Attempt to read property "post_content" on null in /home/rock/Dev/code/lifterlms/includes/functions/llms.functions.templates.loop.php on line 61
[31-Jul-2023 07:11:46 UTC] PHP Deprecated:  str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in /shared/httpd/mywp/wordpress.git/wp-includes/formatting.php on line 2484
[31-Jul-2023 07:11:46 UTC] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /shared/httpd/mywp/wordpress.git/wp-includes/formatting.php on line 449

System and Environment Information

LifterLMS 7.2.1
PHP 8.1

This issue has been recreated:

• Locally
• On a staging site
• On a production website
• With only LifterLMS and a default theme

Browser, Device, and Operating System Information

n/a