Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The defined function name is different from the name in function_exists. #2550

Closed
4 tasks done
actuallyakash opened this issue Oct 13, 2023 · 0 comments · Fixed by #2551 or #2546
Closed
4 tasks done

The defined function name is different from the name in function_exists. #2550

actuallyakash opened this issue Oct 13, 2023 · 0 comments · Fixed by #2551 or #2546
Assignees
@actuallyakash
Labels
good first issue If you're a first time contributor this is a good issue for you! Severity: Normal Status: Has PR This issue has an open pull request Type: Bug Bugs and errors

Comments

@actuallyakash
Copy link
Contributor

Reproduction Steps

function_exists name: https://github.com/gocodebox/lifterlms/blob/dev/includes/functions/llms.functions.templates.dashboard.php#L13

Function name: https://github.com/gocodebox/lifterlms/blob/dev/includes/functions/llms.functions.templates.dashboard.php#L27

Expected Behavior

They should be the same.

Actual Behavior

They are different.

This issue has be recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme
@eri-trabiccolo eri-trabiccolo added Type: Bug Bugs and errors good first issue If you're a first time contributor this is a good issue for you! Severity: Normal labels Oct 13, 2023
@actuallyakash actuallyakash mentioned this issue Oct 13, 2023
Merged
4 tasks
@eri-trabiccolo eri-trabiccolo mentioned this issue Oct 16, 2023
Merged
@eri-trabiccolo eri-trabiccolo added the Status: Has PR This issue has an open pull request label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@actuallyakash actuallyakash

Labels
good first issue If you're a first time contributor this is a good issue for you! Severity: Normal Status: Has PR This issue has an open pull request Type: Bug Bugs and errors
Projects
Development
Status: Done
Milestone
No milestone
2 participants
@eri-trabiccolo @actuallyakash