Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add current item classes to catalogs #257

Closed
thomasplevy opened this issue Nov 8, 2016 · 0 comments
Closed

add current item classes to catalogs #257

thomasplevy opened this issue Nov 8, 2016 · 0 comments
Labels
good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue Status: Can't Recreate Unable to recreate using the provided information or recreation steps
Milestone
Scrub July 2018

Comments

@thomasplevy
Copy link
Contributor

thomasplevy commented Nov 8, 2016 •
edited

This is a theme compatibility enhancement

If you add a course / membership catalog page to a navigation menu the current menu item class should exist on the element when on the catalog page

WooCommerce has a good strategy for this: https://github.com/woocommerce/woocommerce/blob/7959a865f4e0883c7af90ae4c0b1b5f1ad0b2ca8/includes/wc-page-functions.php#L143

Requires better recreation to see if this is still an issue
@thomasplevy thomasplevy added this to the LifterLMS 3.3.0 milestone Nov 8, 2016
@thomasplevy thomasplevy modified the milestone: LifterLMS 3.3.0 Jan 4, 2017
@thomasplevy thomasplevy added good first issue If you're a first time contributor this is a good issue for you! help wanted Looking for contributors to assist with this issue labels Mar 27, 2018
@thomasplevy thomasplevy added the hacktoberfest PRs for this issue count towards Hacktoberfest contributions! label Apr 11, 2018
@thomasplevy thomasplevy added this to the Scrub May 2018 milestone May 1, 2018
@thomasplevy thomasplevy added the Status: Can't Recreate Unable to recreate using the provided information or recreation steps label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue If you're a first time contributor this is a good issue for you! hacktoberfest PRs for this issue count towards Hacktoberfest contributions! help wanted Looking for contributors to assist with this issue Status: Can't Recreate Unable to recreate using the provided information or recreation steps
Projects
None yet
Milestone
Scrub July 2018
Development

No branches or pull requests
2 participants
@thomasplevy @actual-saurabh