Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Use httptest instead of manually running HTTP server #83

Closed
peterhellberg opened this issue Jan 5, 2018 · 3 comments
Closed

Suggestion: Use httptest instead of manually running HTTP server #83

peterhellberg opened this issue Jan 5, 2018 · 3 comments

Comments

@peterhellberg
Copy link
Contributor

Currently there is code in the tests manually running a HTTP server to run test against, this is what the net/http/httptest package is meant to be used for.
@asciimoo
Copy link
Member

asciimoo commented Jan 5, 2018

You're right, it would be a better solution. Would you like to work on this?

@peterhellberg
Copy link
Contributor Author

Yes, I've used *httptest.Server in a few projects before so there shouldn't be any surprises…

I can take a look at making this change later, but first I'm going to visit my grandmother 😃

@peterhellberg peterhellberg mentioned this issue Jan 6, 2018
Merged
@asciimoo
Copy link
Member

asciimoo commented Jan 6, 2018

Implemented: 132289a
Thank you!

@asciimoo asciimoo closed this as completed Jan 6, 2018
vadimkhvost pushed a commit to vadimkhvost/collygolang that referenced this issue May 19, 2020
@peterhellberg
Use *httptest.Server in tests, remove init func
fab0090 
Related to gocolly/colly#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asciimoo @peterhellberg