Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional options for NewCollector #82

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Add functional options for NewCollector #82

merged 1 commit into from
Jan 5, 2018

Conversation

peterhellberg
Copy link
Contributor

Issue #80

@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #82 into master will increase coverage by 3.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #82      +/-   ##
=========================================
+ Coverage   43.01%   46.8%   +3.78%     
=========================================
  Files           7       7              
  Lines         744     797      +53     
=========================================
+ Hits          320     373      +53     
  Misses        385     385              
  Partials       39      39
Impacted Files Coverage Δ
cmd/colly/colly.go 46.93% <0%> (+6.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88ceb0...2ae5e16. Read the comment docs.

Copy link
Member

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Wow, that was fast and the code is clean and understandable.
Thank you for your valuable contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants