Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conn: send heartbeats to detect dead connections #1258

Merged
merged 1 commit into from Jan 26, 2019
Merged

conn: send heartbeats to detect dead connections #1258

merged 1 commit into from Jan 26, 2019

Conversation

Zariel
Copy link
Member

@Zariel Zariel commented Jan 26, 2019

fixes #1139

@Zariel Zariel merged commit 8516aab into gocql:master Jan 26, 2019
@Zariel Zariel deleted the conn/heartbeat branch January 26, 2019 12:35
@MichaelS11 MichaelS11 mentioned this pull request Jan 29, 2019
Closed
@MichaelS11
Copy link
Contributor

The heartBeat goroutine does not seem to get closed and have a lot of them alive.

Example:

goroutine 34308 [select]:
github.com/gocql/gocql.(*Conn).heartBeat(0xc4232b2b00)
/build/go/src/github.com/gocql/gocql/conn.go:525 +0x160
created by github.com/gocql/gocql.(*Session).dial
/build/go/src/github.com/gocql/gocql/conn.go:259 +0x7c6

Could #1139 be reopened?

@MichaelS11
Copy link
Contributor

@Zariel Could you please look at this PR again? The heartBeat goroutine does not seem to close correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when Cassandra connection issues
2 participants
@Zariel @MichaelS11