policy: roundrobbin should try all up hosts #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of keep a global position to iterate around a ring of hosts just shuffle all the hosts and return hosts which are up. Fix finding the correct token in the token ring for host selection. Simplify the tests so that they only test things they are inteded to test, let other tests verify that DCAwareRR works for example.
alourie
approved these changes
Sep 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keep a global position to iterate around a ring of hosts just
shuffle all the hosts and return hosts which are up.
Fix finding the correct token in the token ring for host selection.
Simplify the tests so that they only test things they are inteded to
test, let other tests verify that DCAwareRR works for example.