Adding support for enqueue unique by specified key #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 6, 2018 11:02
Allow enqueueing unique jobs based on specified key
shdunning
requested changes
Sep 12, 2018
enqueue.go
Outdated
| rawJSON, err := job.serialize() | ||
| // EnqueueUniqueByKeyIn enqueues a job in the scheduled job queue that is unique on specified key for execution in secondsFromNow seconds. See EnqueueUnique for the semantics of unique jobs. | ||
| // Subsequent calls with same key will update arguments | ||
| func (e *Enqueuer) EnqueueUniqueByKeyIn(jobName string, secondsFromNow int64, args map[string]interface{}, keyMap map[string]interface{}) (*ScheduledJob, error) { |
There was a problem hiding this comment.
🤔 i think EnqueueUniqueInByKey is a better fit for the name.
enqueue_test.go
Outdated
| assert.EqualValues(t, 2, wats) | ||
| assert.EqualValues(t, 1, taws) | ||
|
|
||
| // Chewck that arguments got updated to new value |
| @@ -348,22 +348,28 @@ return requeuedCount | |||
| // KEYS[1] = job queue to push onto | |||
| // KEYS[2] = Unique job's key. Test for existence and set if we push. | |||
| // ARGV[1] = job | |||
| // ARGV[2] = updated job or just a 1 if arguments don't update | |||
There was a problem hiding this comment.
ARGV[2] is updated job args, right?
| end | ||
| return 'dup' | ||
| ` | ||
|
|
||
| // KEYS[1] = scheduled job queue | ||
| // KEYS[2] = Unique job's key. Test for existence and set if we push. | ||
| // ARGV[1] = job | ||
| // ARGV[2] = epoch seconds for job to be run at | ||
| // ARGV[2] = updated job or just a 1 if arguments don't update |
|
@shdunning Wish to see this feature get released, it is just available in |
|
Hello, can we make a new release for the feature, it is very useful for me |
|
@taylorchu , could you please create a new release 0.5.2 include the latest features in master? thanks |
kh411d
reviewed
Oct 13, 2022
| var redisLuaEnqueueUniqueIn = ` | ||
| if redis.call('set', KEYS[2], '1', 'NX', 'EX', '86400') then | ||
| redis.call('zadd', KEYS[1], ARGV[2], ARGV[1]) | ||
| if redis.call('set', KEYS[2], ARGV[2], 'NX', 'EX', '86400') then |
There was a problem hiding this comment.
Why is the TTL not following the secondsFromNow value, instead being always 24h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9