-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRD recommendationRule #58
Conversation
|
|
|
Use recommender's name to link to RecommenderConfiguration now. Pls take a look again. |
// +kubebuilder:object:root=true | ||
// +kubebuilder:resource:scope=Cluster,shortName=rr | ||
|
||
// RecommendationRule represents the configuration of an RecommendationRule object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest change to RecommendationRule is the rule to select kubernetes resource and recommender.
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
// +optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec is optional?
// NamespaceSelector indicates resource namespaces to select from | ||
NamespaceSelector NamespaceSelector `json:"namespaceSelector"` | ||
|
||
// RunInterval between two recommendation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we point out the default interval?
|
||
// Recommender referring to the Recommender in RecommendationConfiguration | ||
type Recommender struct { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the row
// Recommendations is a list of RecommendationMission that run parallel. | ||
// +optional | ||
// +listType=atomic | ||
Recommendations []RecommendationMission `json:"recommendations,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we use recommendation mission?
RecommendationRule defines how to select resource for recommendation. We want to simplify the usage for Analytics.
This is a sample yaml for workload recommendation:
This is a sample yaml for service recommendation:
recommenders is referring to RecommenderConfiguration Recommender's type