Propagate labels and annotations from ehpa to hpa #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkaiyue
force-pushed
the
propagate-ehpa-labels-annotations
branch
from
a7c2cb6
to
504a947
Compare
qmhu
reviewed
Feb 14, 2022
pkg/controller/ehpa/hpa.go
Outdated
| hpa.Labels[key] = value | ||
| } | ||
| } | ||
| for _, prefix := range c.Config.PropagationConfig.Labels { |
pkg/controller/ehpa/hpa.go
Outdated
| hpa.Annotations[key] = value | ||
| } | ||
| } | ||
| for _, prefix := range c.Config.PropagationConfig.Annotations { |
|
Changes for helm-charts: gocrane/helm-charts#23 |
chenkaiyue
force-pushed
the
propagate-ehpa-labels-annotations
branch
2 times, most recently
from
b57184c
to
5935019
Compare
|
|
chenkaiyue
force-pushed
the
propagate-ehpa-labels-annotations
branch
from
5935019
to
e84c4f2
Compare
chenkaiyue
force-pushed
the
propagate-ehpa-labels-annotations
branch
from
e84c4f2
to
b17ca87
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For feature #125