Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine cron metrics priority for ehpa when working with other hpa met… #258

Conversation

kitianFresh
Copy link
Contributor

refine cron metrics priority for ehpa when working with other hpa metrics together, remove the cron impact when it is not active

What type of PR is this?

Feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #257

Special notes for your reviewer:

@kitianFresh kitianFresh self-assigned this Apr 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

♻️ PR Preview a0915bb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@kitianFresh kitianFresh requested a review from qmhu April 11, 2022 10:03
pkg/utils/ehpa/ehpa.go Outdated Show resolved Hide resolved
@kitianFresh kitianFresh force-pushed the feature/refine-cron-priority-when-working-with-other-metrics-together branch 2 times, most recently from 7541577 to db33a21 Compare April 18, 2022 14:41
…rics together, remove the cron impact when it is not active
@kitianFresh kitianFresh force-pushed the feature/refine-cron-priority-when-working-with-other-metrics-together branch from db33a21 to a0915bb Compare April 19, 2022 04:52
@qmhu
Copy link
Member

qmhu commented Apr 19, 2022

/LGTM

@kitianFresh kitianFresh merged commit da8531e into gocrane:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refine cron metric priority when working with other metric together
2 participants