Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust metric labels for EHPA #322

Merged
merged 1 commit into from
May 18, 2022
Merged

Adjust metric labels for EHPA #322

merged 1 commit into from
May 18, 2022

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented May 18, 2022

What type of PR is this?

Bugfix

What this PR does / why we need it:

  1. use namespace and name to replace resourceName
  2. remove unsuitable labels in metrics

Which issue(s) this PR fixes:

Fixes #318

Special notes for your reviewer:

2. remove unsuitable labels in metrics
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-322-087b5c5 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-322-087b5c5
dashboard:pr-322-087b5c5 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-322-087b5c5
metric-adapter:pr-322-087b5c5 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-322-087b5c5
craned:pr-322-087b5c5 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-322-087b5c5

@qmhu qmhu merged commit 2e22cd2 into gocrane:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EHPA metrics for monit crane_autoscaling_effective_hpa_replicas
1 participant