Improve crane agent doc #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview f651a2a has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
qmhu
reviewed
Jul 18, 2022
There was a problem hiding this comment.
Better to make sure document format is consistence with others like: https://github.com/gocrane/crane/blob/main/docs/tutorials/using-effective-hpa-to-scaling-with-effectiveness.zh.md
It's more effective to have some overall summary for Entire QoS features in the documents.
chenkaiyue
force-pushed
the
doc/improve-agent-doc
branch
from
81eb654
to
f651a2a
Compare
qmhu
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What this PR does / why we need it:
Improve Crane agent's doc