Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): remove unnecessary grafana dashboard query str #429

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

PatrickLai7528
Copy link
Collaborator

What type of PR is this?

Remove unnecessary grafana dashboard query str

What this PR does / why we need it:

In some cases, adding ?query=% to /grafana/api/search will cause an error.
image

And I have tried that everything is working fine after removing ?query=%

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-429-73fda9b docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-429-73fda9b
dashboard:pr-429-73fda9b docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-429-73fda9b
metric-adapter:pr-429-73fda9b docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-429-73fda9b
craned:pr-429-73fda9b docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-429-73fda9b

Copy link
Member

@zsnmwy zsnmwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zsnmwy zsnmwy merged commit 8871293 into gocrane:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants