Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that removeExtremeOutliers not called. #430

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fix the bug that removeExtremeOutliers not called. #430

merged 1 commit into from
Jul 27, 2022

Conversation

yufeiyu
Copy link
Contributor

@yufeiyu yufeiyu commented Jul 27, 2022

What type of PR is this?

bugfix

What this PR does / why we need it:

Fix the bug that removeExtremeOutliers not called.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-430-d1d048a docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-430-d1d048a
dashboard:pr-430-d1d048a docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-430-d1d048a
metric-adapter:pr-430-d1d048a docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-430-d1d048a
craned:pr-430-d1d048a docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-430-d1d048a

qmhu
qmhu approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to change PR's title to a meaningful sentence.

@yufeiyu yufeiyu changed the title fix bug Fix the bug that removeExtremeOutliers not called. Jul 27, 2022
@yufeiyu
Copy link
Contributor Author

yufeiyu commented Jul 27, 2022

changed

@yufeiyu yufeiyu merged commit 82e4676 into gocrane:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmhu qmhu qmhu approved these changes

@chenkaiyue chenkaiyue Awaiting requested review from chenkaiyue

@kitianFresh kitianFresh Awaiting requested review from kitianFresh

@mfanjie mfanjie Awaiting requested review from mfanjie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yufeiyu @qmhu