Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ci build arm images #466

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix: ci build arm images #466

merged 1 commit into from
Aug 10, 2022

Conversation

zsnmwy
Copy link
Member

@zsnmwy zsnmwy commented Aug 9, 2022

What type of PR is this?

Fix: arm image not working.

What happened?

The go build built the x86 binary in the arm env because of the const build args - CGO_ENABLED=0 GOOS=linux GOARCH=amd64.
But we don't need to set the go build args in the Dockerfile.
The go build can get the compile flags from the build env.


root@VM-0-28-ubuntu:~# uname -a
Linux VM-0-28-ubuntu 5.4.0-104-generic #118-Ubuntu SMP Wed Mar 2 19:03:41 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
root@VM-0-28-ubuntu:~# file metric-adapter 
metric-adapter: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-aarch64.so.1, Go BuildID=ymgyrPjIz3jkF6OdMcLJ/iH3dROJRkpIzlx57H06V/g1YpaX-I2yDYE-jFtK-b/iKOPV8g7qn4jOMga5Izi, not stripped

image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

♻️ PR Preview 52cd943 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@zsnmwy zsnmwy force-pushed the fix/ci_arm_build branch 2 times, most recently from 83e83bc to fdec538 Compare August 9, 2022 14:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-10 10:29
Git Version: 52cd943

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-466-52cd943 docker pull gocrane/crane-agent:pr-466-52cd943
dashboard:pr-466-52cd943 docker pull gocrane/dashboard:pr-466-52cd943
metric-adapter:pr-466-52cd943 docker pull gocrane/metric-adapter:pr-466-52cd943
craned:pr-466-52cd943 docker pull gocrane/craned:pr-466-52cd943

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-466-52cd943 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-466-52cd943
dashboard:pr-466-52cd943 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-466-52cd943
metric-adapter:pr-466-52cd943 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-466-52cd943
craned:pr-466-52cd943 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-466-52cd943

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-466-52cd943 docker pull ghcr.io/gocrane/crane/crane-agent:pr-466-52cd943
dashboard:pr-466-52cd943 docker pull ghcr.io/gocrane/crane/dashboard:pr-466-52cd943
metric-adapter:pr-466-52cd943 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-466-52cd943
craned:pr-466-52cd943 docker pull ghcr.io/gocrane/crane/craned:pr-466-52cd943

Signed-off-by: zsnmwy <szlszl35622@gmail.com>
@zsnmwy zsnmwy merged commit f73c266 into gocrane:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants